Feature: add user common types to pb impl#5289
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
Bot
added
the
pr-feature
drmingdrmer
approved these changes
May 10, 2022
Comment on lines
+30
to
+32
| pub use util::check_ver; | ||
| pub use util::missing; | ||
| pub use util::VER; |
Comment on lines
+24
to
+40
| message None {} | ||
| message Password { | ||
| enum PasswordHashMethod { | ||
| PlainText = 0; | ||
| DoubleSha1 = 1; | ||
| Sha256 = 2; | ||
| } | ||
| bytes hash_value = 1; | ||
| PasswordHashMethod hash_method = 2; | ||
| } | ||
| message JWT {} | ||
|
|
||
| oneof info { | ||
| None none = 1; | ||
| Password password = 2; | ||
| JWT jwt = 3; | ||
| } |
Member
There was a problem hiding this comment.
What aboutt using a single Empty message for all kinds of enum variants that do not have a body?
Using Empty for None and JWT will get rid of several empty messages.
I.e., trade specificity for simplicity.
Member
|
Add: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
from_to_protobuf_impl.rsinto{database|table|data}_rs.Changelog
Related Issues
Part of #5221