Skip to content

feat(planner): display error with source span#5290

Merged
bohutang merged 3 commits into
databendlabs:mainfrom
andylokandy:span
May 10, 2022
Merged

feat(planner): display error with source span#5290
bohutang merged 3 commits into
databendlabs:mainfrom
andylokandy:span

Conversation

@andylokandy

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

// V1
- ERROR 1105 (HY000) at line 4: Code: 1058, displayText = Unknown column aa.
- ERROR 1105 (HY000) at line 5: Code: 1015, displayText = SELECT * with no tables specified is not valid (while in analyze select projection).

// V2
+ ERROR 1105 (HY000) at line 4: Code: 1065, displayText = error: 
+   --> SQL:1:8
+   |
+ 1 | select aa from t
+   |        ^^ column doesn't exist
+ 
+ .
+ ERROR 1105 (HY000) at line 5: Code: 1065, displayText = error: 
+   --> SQL:1:1
+   |
+ 1 | select *
+   | ^^^^^^^^ SELECT * with no tables specified is not valid
+ 
+ .

Changelog

  • New Feature

@vercel

vercel Bot commented May 10, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 10, 2022 at 5:08PM (UTC)

@andylokandy
andylokandy requested a review from leiysky May 10, 2022 16:36
@mergify

mergify Bot commented May 10, 2022

Copy link
Copy Markdown
Contributor

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify Bot added the pr-feature this PR introduces a new feature to the codebase label May 10, 2022
@bohutang
bohutang merged commit ed54bf4 into databendlabs:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants