Skip to content

[exception] better exception#545

Merged
sundy-li merged 1 commit into
databendlabs:masterfrom
sundy-li:issue-537
May 14, 2021
Merged

[exception] better exception#545
sundy-li merged 1 commit into
databendlabs:masterfrom
sundy-li:issue-537

Conversation

@sundy-li

Copy link
Copy Markdown
Member

Summary

Better exceptions for clickhouse server.

Changelog

  • Improvement

Related Issues

closes #537

Test Plan

Unit tests.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #545 (0e4a6e7) into master (31a2449) will decrease coverage by 0%.
The diff coverage is 29%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #545   +/-   ##
======================================
- Coverage      79%     79%   -1%     
======================================
  Files         284     284           
  Lines       13138   13141    +3     
======================================
+ Hits        10497   10499    +2     
- Misses       2641    2642    +1     
Impacted Files Coverage Δ
common/exception/src/exception.rs 32% <29%> (-3%) ⬇️
common/runtime/src/runtime_test.rs 53% <0%> (-14%) ⬇️
fusequery/query/src/sql/plan_parser.rs 77% <0%> (+<1%) ⬆️
common/datavalues/src/data_value.rs 30% <0%> (+<1%) ⬆️
...query/src/pipelines/processors/pipeline_builder.rs 76% <0%> (+<1%) ⬆️
fusequery/query/src/api/rpc/flight_service.rs 65% <0%> (+<1%) ⬆️
common/datavalues/src/macros.rs 48% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a2449...0e4a6e7. Read the comment docs.

@bohutang bohutang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @sundy-li

@sundy-li
sundy-li merged commit 7dec6b9 into databendlabs:master May 14, 2021
@sundy-li
sundy-li deleted the issue-537 branch May 14, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClickHouse client: handler in the server side can not catche the error

3 participants