Skip to content

feat: undrop database#5770

Merged
bohutang merged 3 commits into
databendlabs:mainfrom
LiuYuHui:undrop_state
Jun 4, 2022
Merged

feat: undrop database#5770
bohutang merged 3 commits into
databendlabs:mainfrom
LiuYuHui:undrop_state

Conversation

@LiuYuHui

@LiuYuHui LiuYuHui commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Implement undrop database statement.

Changelog

  • New Feature

Related Issues

Fixes #5701

@vercel

vercel Bot commented Jun 4, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 4, 2022 at 10:34AM (UTC)

@mergify

mergify Bot commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify Bot added the pr-feature this PR introduces a new feature to the codebase label Jun 4, 2022
@bohutang
bohutang requested a review from dantengsky June 4, 2022 09:03
@dantengsky

Copy link
Copy Markdown
Member

@LiuYuHui

Nice work!

As you might already noticed that Hive catalog should also impl the method async fn undrop_database.

https://github.com/datafuselabs/databend/runs/6737371920?check_suite_focus=true#step:3:1368

The feature hive is not enabled by default, to eable it we need something like this:

cargo build --bin databend-query --features hive

then we can check if it compiles.

@dantengsky dantengsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bohutang

bohutang commented Jun 4, 2022

Copy link
Copy Markdown
Member

Nice job!
Thanks for your contribution.

@bohutang
bohutang merged commit f4770cc into databendlabs:main Jun 4, 2022
@LiuYuHui
LiuYuHui deleted the undrop_state branch June 5, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: undrop database statement

4 participants