Skip to content

[groupby] fix some hotpath codes for performance#631

Merged
sundy-li merged 1 commit into
databendlabs:masterfrom
sundy-li:aggr-improve
May 26, 2021
Merged

[groupby] fix some hotpath codes for performance#631
sundy-li merged 1 commit into
databendlabs:masterfrom
sundy-li:aggr-improve

Conversation

@sundy-li

Copy link
Copy Markdown
Member

Summary

Fix some hotpath codes to improve the performance

Changelog

Fix the performance drop introduced in #550

  • Improvement

Related Issues

Fixes #619

Test Plan

Performances tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your title and description.

Please review the labels and make any necessary changes.

@sundy-li

Copy link
Copy Markdown
Member Author

Before

SELECT
    min(number),
    max(number),
    number % 3
FROM numbers_mt(100000000)
GROUP BY number % 3

┌─min(number)─┬─max(number)─┬─(number % 3)─┐
│           1 │    99999997 │            1 │
│           2 │    99999998 │            2 │
│           0 │    99999999 │            0 │
└─────────────┴─────────────┴──────────────┘
↑ Progress: 100.00 million rows, 800.72 MB (94.97 million rows/s., 760.48 MB/s.)
3 rows in set. Elapsed: 1.053 sec. Processed 100.00 million rows, 800.72 MB (94.97 million rows/s., 760.45 MB/s.)

After:

datafuse :)  SELECT min(number), max(number),number%3 FROM numbers_mt (100000000) GROUP BY number%3 ;

SELECT
    min(number),
    max(number),
    number % 3
FROM numbers_mt(100000000)
GROUP BY number % 3

┌─min(number)─┬─max(number)─┬─(number % 3)─┐
│           1 │    99999997 │            1 │
│           0 │    99999999 │            0 │
│           2 │    99999998 │            2 │
└─────────────┴─────────────┴──────────────┘
↗ Progress: 100.00 million rows, 800.72 MB (220.50 million rows/s., 1.77 GB/s.)
3 rows in set. Elapsed: 0.454 sec. Processed 100.00 million rows, 800.72 MB (220.48 million rows/s., 1.77 GB/s.)

cc @lideen999

@sundy-li
sundy-li merged commit b61601a into databendlabs:master May 26, 2021
@sundy-li
sundy-li deleted the aggr-improve branch May 26, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After merging Refactor expressions #550, the performance of aggregate is low.

3 participants