Skip to content

[planners] rename ExpressionAction -> Expression#635

Merged
databend-bot merged 2 commits into
databendlabs:masterfrom
sundy-li:rename-expression
May 26, 2021
Merged

[planners] rename ExpressionAction -> Expression#635
databend-bot merged 2 commits into
databendlabs:masterfrom
sundy-li:rename-expression

Conversation

@sundy-li

Copy link
Copy Markdown
Member

Summary

Rename:

  1. ExpressionAction --> Expression, because Expression is a modern name for SQL expressions.
  2. ActionNode --> ExpressionAction, that's the better name for ExpressionAction

Changelog

  • Improvement

Related Issues

Test Plan

Unit Tests
Stateless Tests

@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your title and description.

Please review the labels and make any necessary changes.

@codecov-commenter

codecov-commenter commented May 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #635 (6759f6a) into master (8ed7986) will increase coverage by 0%.
The diff coverage is 81%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #635   +/-   ##
======================================
  Coverage      80%     80%           
======================================
  Files         286     284    -2     
  Lines       13782   13770   -12     
======================================
- Hits        11094   11085    -9     
+ Misses       2688    2685    -3     
Impacted Files Coverage Δ
...y/src/pipelines/transforms/transform_expression.rs 75% <ø> (ø)
...rc/pipelines/transforms/transform_groupby_final.rs 80% <ø> (ø)
...y/src/pipelines/transforms/transform_projection.rs 74% <ø> (ø)
...y/src/pipelines/transforms/transform_sort_merge.rs 79% <ø> (ø)
common/planners/src/plan_expression_literal.rs 50% <42%> (ø)
common/planners/src/plan_rewriter.rs 51% <43%> (ø)
.../pipelines/transforms/transform_groupby_partial.rs 78% <50%> (ø)
common/planners/src/plan_expression_chain.rs 37% <63%> (ø)
fusequery/query/src/sql/plan_parser.rs 86% <78%> (+<1%) ⬆️
common/planners/src/plan_expression_visitor.rs 82% <85%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ed7986...6759f6a. Read the comment docs.

@bohutang
bohutang requested review from bohutang and zhang2014 May 26, 2021 23:32
@bohutang
bohutang self-requested a review May 26, 2021 23:44
@databend-bot
databend-bot merged commit 1edd027 into databendlabs:master May 26, 2021
@bohutang bohutang mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants