Skip to content

[mysql] add hints parser and tests#843

Merged
databend-bot merged 6 commits into
databendlabs:masterfrom
sundy-li:hint
Jun 17, 2021
Merged

[mysql] add hints parser and tests#843
databend-bot merged 6 commits into
databendlabs:masterfrom
sundy-li:hint

Conversation

@sundy-li

@sundy-li sundy-li commented Jun 16, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

  • Update test result style, introduce --record for fuse-test to override the results
  • Add Comment Hints support for mysql server, eg:
 SELECT b.number FROM (SELECT * FROM numbers(3) AS b) AS a ORDER BY b.number; -- {ErrorCode 25}

Changelog

  • New Feature
  • Improvement

Related Issues

Fixes #717

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added pr-feature this PR introduces a new feature to the codebase pr-improvement labels Jun 16, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter

codecov-commenter commented Jun 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #843 (42e7918) into master (9c7c7fa) will increase coverage by 0%.
The diff coverage is 82%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #843   +/-   ##
======================================
  Coverage      78%     78%           
======================================
  Files         326     326           
  Lines       17858   17923   +65     
======================================
+ Hits        13967   14019   +52     
- Misses       3891    3904   +13     
Impacted Files Coverage Δ
fusequery/query/src/sql/plan_parser.rs 76% <60%> (-1%) ⬇️
fusequery/query/src/sql/sql_statement.rs 80% <81%> (+<1%) ⬆️
fusequery/query/src/sql/sql_parser.rs 78% <87%> (+<1%) ⬆️
fusequery/query/src/sql/sql_parser_test.rs 92% <100%> (+1%) ⬆️
common/runtime/src/runtime_test.rs 66% <0%> (-7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7c7fa...42e7918. Read the comment docs.

@sundy-li
sundy-li requested review from bohutang and zhang2014 June 17, 2021 02:53
@sundy-li
sundy-li marked this pull request as ready for review June 17, 2021 02:54

@zhang2014 zhang2014 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@databend-bot

Copy link
Copy Markdown
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot
databend-bot merged commit 0cb133b into databendlabs:master Jun 17, 2021
@sundy-li
sundy-li deleted the hint branch June 17, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tests] Tests support error code match rather than error text.

4 participants