Skip to content

feat: implement drop user defined catalog - #8820

Merged
bohutang merged 3 commits into
databendlabs:mainfrom
ClSlaid:multiple-catalog/drop-catalog
Nov 17, 2022
Merged

feat: implement drop user defined catalog#8820
bohutang merged 3 commits into
databendlabs:mainfrom
ClSlaid:multiple-catalog/drop-catalog

Conversation

@ClSlaid

@ClSlaid ClSlaid commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: 蔡略 cailue@bupt.edu.cn

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

This PR implements the drop feature of multiple catalogs

Notes:

  1. default catalog is not allowed to be dropped, a CatalogNotSupported error will be returned
  2. dropping unknown catalogs without IF EXISTS will return a UnknownCatalog error

Previews

  1. create and drop by SQL
    图片

  2. drop unknown catalog
    图片

  3. drop default catalog
    图片

Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
@vercel

vercel Bot commented Nov 16, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 17, 2022 at 5:22AM (UTC)

@mergify mergify Bot added the pr-feature this PR introduces a new feature to the codebase label Nov 16, 2022
@ClSlaid
ClSlaid marked this pull request as ready for review November 16, 2022 12:30
@ClSlaid
ClSlaid requested a review from bohutang November 16, 2022 12:30
@bohutang
bohutang requested a review from Xuanwo November 16, 2022 23:08
@ClSlaid
ClSlaid removed the request for review from bohutang November 17, 2022 04:31

@Xuanwo Xuanwo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM!

Comment thread src/common/exception/src/exception_code.rs Outdated
Signed-off-by: 蔡略 <cailue@bupt.edu.cn>
@bohutang
bohutang merged commit 1b6176d into databendlabs:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants