Skip to content

refactor(memory-tracker): remove RuntimeTracker, which is barely a wrapper of Arc of MemoryTracker - #8859

Merged
bohutang merged 1 commit into
databendlabs:mainfrom
drmingdrmer:52-rm-runtime-tracker
Nov 20, 2022
Merged

refactor(memory-tracker): remove RuntimeTracker, which is barely a wrapper of Arc of MemoryTracker#8859
bohutang merged 1 commit into
databendlabs:mainfrom
drmingdrmer:52-rm-runtime-tracker

Conversation

@drmingdrmer

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

refactor(memory-tracker): remove RuntimeTracker, which is barely a wrapper of Arc of MemoryTracker

Changelog

Related Issues

@vercel

vercel Bot commented Nov 20, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Nov 20, 2022 at 1:16PM (UTC)

@drmingdrmer
drmingdrmer marked this pull request as ready for review November 20, 2022 12:54
@drmingdrmer
drmingdrmer requested review from bohutang and zhang2014 and removed request for zhang2014 November 20, 2022 12:54
@mergify mergify Bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 20, 2022
@bohutang

Copy link
Copy Markdown
Member

It looks better to move src/common/base/src/base/runtime*.rs to a single crate in src/common/runtime.
Let's do it in the later, low priority :)

@bohutang

Copy link
Copy Markdown
Member
error[E0432]: unresolved import `common_base::base::RuntimeTracker`
  --> src/binaries/query/main.rs:18:5
   |
18 | use common_base::base::RuntimeTracker;
   |     ^^^^^^^^^^^^^^^^^^^--------------
   |     |                  |
   |     |                  help: a similar name exists in the module: `runtime_tracker`
   |     no `RuntimeTracker` in `base`

error[E0432]: unresolved import `common_base::base::RuntimeTracker`
  --> src/binaries/meta/main.rs:19:5
   |
19 | use common_base::base::RuntimeTracker;
   |     ^^^^^^^^^^^^^^^^^^^--------------
   |     |                  |
   |     |                  help: a similar name exists in the module: `runtime_tracker`
   |     no `RuntimeTracker` in `base`

@drmingdrmer
drmingdrmer force-pushed the 52-rm-runtime-tracker branch from 8041b32 to 66c7f13 Compare November 20, 2022 13:13
@drmingdrmer
drmingdrmer force-pushed the 52-rm-runtime-tracker branch from 66c7f13 to acc0de3 Compare November 20, 2022 13:16
@bohutang
bohutang merged commit 5d3a308 into databendlabs:main Nov 20, 2022
@drmingdrmer
drmingdrmer deleted the 52-rm-runtime-tracker branch November 20, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants