Skip to content

feat(query): unset max_threads/memory_usage should recover to start value - #8883

Merged
bohutang merged 2 commits into
databendlabs:mainfrom
TCeason:ISSUE-8881
Nov 22, 2022
Merged

feat(query): unset max_threads/memory_usage should recover to start value#8883
bohutang merged 2 commits into
databendlabs:mainfrom
TCeason:ISSUE-8881

Conversation

@TCeason

@TCeason TCeason commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. unset max_threads/memory_usage should recover to start value
  2. max_memory_usage modify to : total_memory * 0.8

Closes #8881

@vercel

vercel Bot commented Nov 21, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 6:46AM (UTC)

@mergify mergify Bot added the pr-feature this PR introduces a new feature to the codebase label Nov 21, 2022
@TCeason
TCeason marked this pull request as draft November 21, 2022 16:38
@TCeason
TCeason marked this pull request as ready for review November 22, 2022 00:51
Comment thread src/query/service/src/interpreters/interpreter_unsetting.rs Outdated
Comment thread src/query/service/tests/it/storages/testdata/system-tables.txt Outdated
Comment thread src/query/service/src/interpreters/interpreter_unsetting.rs
@bohutang
bohutang merged commit d7aa8a9 into databendlabs:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: unset max_threads should set detect val

3 participants