Skip to content

ISSUE-938: Datafuse CLI#950

Merged
bohutang merged 25 commits into
databendlabs:masterfrom
bohutang:dev-cli-938
Jul 31, 2021
Merged

ISSUE-938: Datafuse CLI#950
bohutang merged 25 commits into
databendlabs:masterfrom
bohutang:dev-cli-938

Conversation

@bohutang

@bohutang bohutang commented Jun 30, 2021

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

  • datafuse-cli version
  • datafuse-cli help
  • datafuse-cli update
  • datafuse-cli cluster start
make cli
$ ./target/release/datafuse-cli 
[test] > help
version              Datafuse CLI version
comment              # your comments
update               Check and download the package to local path
cluster              Start the fuse-query and fuse-store service
[test] > #update to latest version
#update to latest version 
[test] > update
Arch                 x86_64-unknown-linux-gnu
Tag                  v0.4.66-nightly
Binary               /home/bohu/.datafuse/test/downloads/datafuse--x86_64-unknown-linux-gnu.tar.gz
Download             https://github.com/datafuselabs/datafuse/releases/download/v0.4.66-nightly/datafuse--x86_64-unknown-linux-gnu.tar.gz
Unpack to            /home/bohu/.datafuse/test/bin/v0.4.66-nightly
[test] > #start fuse-query and fuse-store on local
#start fuse-query and fuse-store on local 
[test] > cluster start
Start [fuse-query] /home/bohu/.datafuse/test/bin/v0.4.66-nightly/fuse-query > /tmp/query-log.txt 2>&1 &
[OK]        
Start [fuse-store] /home/bohu/.datafuse/test/bin/v0.4.66-nightly/fuse-store> /tmp/store-log.txt 2>&1 &
[OK]        
[test] > 

Changelog

  • New Feature

Related Issues

Fixes #938

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Jun 30, 2021
@databend-bot

Copy link
Copy Markdown
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov-commenter

codecov-commenter commented Jun 30, 2021

Copy link
Copy Markdown

Codecov Report

Merging #950 (468a653) into master (fcf93d9) will decrease coverage by 0%.
The diff coverage is 10%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #950     +/-   ##
========================================
- Coverage      71%     71%     -1%     
========================================
  Files         456     474     +18     
  Lines       27212   28751   +1539     
========================================
+ Hits        19586   20682   +1096     
- Misses       7626    8069    +443     
Impacted Files Coverage Δ
fusecli/cli/src/cmds/clusters/cluster.rs 0% <0%> (ø)
fusecli/cli/src/cmds/comments/comment.rs 0% <0%> (ø)
fusecli/cli/src/cmds/env.rs 0% <0%> (ø)
fusecli/cli/src/cmds/helps/help.rs 0% <0%> (ø)
fusecli/cli/src/cmds/processor.rs 0% <0%> (ø)
fusecli/cli/src/cmds/updates/update.rs 0% <0%> (ø)
fusecli/cli/src/cmds/versions/version.rs 0% <0%> (ø)
fusecli/cli/src/cmds/writer.rs 0% <0%> (ø)
fusecli/cli/src/error.rs 16% <0%> (ø)
fusecli/cli/src/cmds/config.rs 53% <55%> (ø)
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf93d9...468a653. Read the comment docs.

#[derive(StructOpt, Debug)]
pub struct VersionCommand {}

impl VersionCommand {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should also support remote tag for version, i.e:
fusecli version --remote=true // show local client version and remote cluster version
fusecli version --remotve=false // only show local client version

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@bohutang

bohutang commented Jul 9, 2021

Copy link
Copy Markdown
Member Author

This will be started after #991

@bohutang
bohutang marked this pull request as ready for review July 31, 2021 16:37
@databend-bot

Copy link
Copy Markdown
Member

Hello @bohutang, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@bohutang
bohutang merged commit 5dd057d into databendlabs:master Jul 31, 2021
@bohutang
bohutang deleted the dev-cli-938 branch July 31, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] bendctl: databend cli

4 participants