chore(appkit): remove deprecated agent() plugin and createAgentApp shortcut#299
Closed
MarioCadenas wants to merge 1 commit intoagent/5f-from-plugin-apifrom
Closed
chore(appkit): remove deprecated agent() plugin and createAgentApp shortcut#299MarioCadenas wants to merge 1 commit intoagent/5f-from-plugin-apifrom
MarioCadenas wants to merge 1 commit intoagent/5f-from-plugin-apifrom
Conversation
…ortcut The `agents()` plugin + `createAgent()` pure factory + `createApp` shape is the canonical public API. The transitional `agent()` plugin and the `createAgentApp` shortcut (renamed-old-createAgent) existed to give callers a migration window; they've been replaced in every in-tree consumer by the new API. Removes: - `packages/appkit/src/plugins/agent/` — entire folder (agent.ts, config-loader.ts, types.ts, manifest.json, tests/). - `packages/appkit/src/core/create-agent.ts` — the app-shortcut variant. Superseded by `packages/appkit/src/core/create-agent-def.ts` (pure factory) combined with `agents()`. - `packages/appkit/src/core/tests/create-agent.test.ts` — tests for the removed shortcut. - `docs/docs/api/appkit/Function.createAgentApp.md` — stale generated API doc. - `agent` and `createAgentApp` exports from `packages/appkit/src/index.ts`, and the `./agent` re-export from `packages/appkit/src/plugins/index.ts`. Docs: the migration guide's "Gradual migration" and "Removal timeline" sections are dropped — they described a coexistence window that no longer exists. The "Name changes at a glance" table now points at the final shape instead of the deprecated alias. No runtime behavior change; callers that were still using the deprecated exports will see a clear import error directing them to the new API. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
This was referenced Apr 21, 2026
Collaborator
Author
|
Superseded by the v2 6-PR stack:
The v2 stack reorganizes the same work so no PR ships API that a later PR deletes. Start at #301 for the new entry point. Branches from this older stack are preserved unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure dead-code removal. With
agents()+createAgent(def)+fromPluginnow covering every use case previously served by the transitionalagent()plugin andcreateAgentAppshortcut, the deprecated surface is removed entirely.Removed
packages/appkit/src/plugins/agent/— entire folder (agent.ts, config-loader.ts, types.ts, manifest.json, tests/)packages/appkit/src/core/create-agent.ts— the oldcreateAgentapp-shortcut. Superseded bypackages/appkit/src/core/create-agent-def.ts(pure factory) combined withagents()packages/appkit/src/core/tests/create-agent.test.ts— tests for the removed shortcutdocs/docs/api/appkit/Function.createAgentApp.md— stale generated API docagentandcreateAgentAppexports frompackages/appkit/src/index.ts, and the./agentre-export frompackages/appkit/src/plugins/index.tsDocs
The migration guide's "Gradual migration" and "Removal timeline" sections are dropped — they described a coexistence window that no longer exists. The "Name changes at a glance" table now points at the final shape instead of the deprecated alias.
Net change
−1,761 lines. No runtime behavior change for anyone on the new API. Anyone still importing
agentorcreateAgentAppwill see a clear module-not-found error pointing at the new exports.PR Stack
agents()plugin +createAgent(def)+.toolkit()— feat(appkit): add agents() plugin, createAgent() factory, and .toolkit() #294agents()— feat(appkit): migrate agent-app and docs to the new agents() plugin #295preparePluginsforwards eager instance — refactor(appkit): forward eager plugin instance through preparePlugins #297fromPlugin()API — feat(appkit): add fromPlugin() for referencing plugin tools in code-defined agents #298agent()+createAgentApp(this PR)toPluginWithInstance+ bug fixes — refactor(appkit): retire toPluginWithInstance; consolidate on fromPlugin + fix schema/routing bugs #300Test plan