Add DELETE endpoint for lakeview dashboards in test server#3045
Merged
Add DELETE endpoint for lakeview dashboards in test server#3045
Conversation
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Jun 12, 2025
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
andrewnester,
pietern and
shreyas-goenka
as code owners
shreyas-goenka
approved these changes
Jun 12, 2025
denik
approved these changes
Jun 12, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
…er mimic the Lakeview API (#3047) ## Changes <!-- Brief summary of your changes that is easy to understand --> ⏺ Change CREATE endpoint for Lakeview dashboards in test server to closer mimic the Lakeview API: - Strip hyphens from dashboard IDs (UUID format) - Set LifecycleState to Active by default - Construct Path from ParentPath + DisplayName when provided - Add pageType field to dashboard pages in serialized content ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> This change will allow local acceptance tests to use the test server instead of defining their own mocks ## Related PRs: #3045 ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#3048) ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> This is the last in the series of changes for using testserver instead of mocks in acceptance tests for dashboards deployment ## Related PRs - #3045 - #3047 ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
This is the first in the series of changes for using testserver instead of mocks in acceptance tests for dashboards deployment
Related PRs:
#3047
Tests