Conversation
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
changed the base branch from
main
to
anton-107/testserver-dashboards-delete
…er mimic the Lakeview API
…UUID as a replacement
anton-107
force-pushed
the
anton-107/testserver-dashboards-create
branch
from
f86b2ad to
68ea6dc
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…tead of UUID as a replacement
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
requested review from
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
shreyas-goenka
approved these changes
Jun 12, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
## Changes <!-- Brief summary of your changes that is easy to understand --> 1. Add DELETE endpoint for lakeview dashboards in test server 1. Remove the mocks for DELETE calls in acceptance tests for dashboards deployment ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> This is the first in the series of changes for using testserver instead of mocks in acceptance tests for dashboards deployment ## Related PRs: #3047 ## Tests <!-- How have you tested the changes? --> <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
…#3048) ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> This is the last in the series of changes for using testserver instead of mocks in acceptance tests for dashboards deployment ## Related PRs - #3045 - #3047 ## Tests <!-- How have you tested the changes? --> Existing tests <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
pietern
reviewed
Jun 16, 2025
| // Change path field if parent_path is provided | ||
| if dashboard.ParentPath != "" { | ||
| dashboard.Path = dashboard.ParentPath + "/" + dashboard.DisplayName + ".lvdash.json" | ||
| } |
Contributor
There was a problem hiding this comment.
What is the behavior if the parent path is not defined?
If this is invalid, then it can return an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
⏺ Change CREATE endpoint for Lakeview dashboards in test server to closer mimic the Lakeview API:
Why
This change will allow local acceptance tests to use the test server instead of defining their own mocks
Related PRs:
#3045
Tests