Fix Lakebase acceptance tests for backend changes#4746
Merged
shreyas-goenka merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
Collaborator
|
Commit: 6d43594
16 interesting tests: 7 SKIP, 6 RECOVERED, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
The backend now auto-creates a "primary" endpoint for new Lakebase instances and returns `enable_pg_native_login` in project responses. - Rename endpoint from "primary" to "custom" in endpoints/basic test - Add `enable_pg_native_login` to the mock server's project response - Update golden files to include the new field Co-authored-by: Isaac
303e87d to
6d43594
Compare
denik
approved these changes
Mar 16, 2026
rauchy
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Summary - Rename endpoint from `primary` to `custom` in `postgres_endpoints/basic` test to avoid conflict with the auto-created primary endpoint - Add `enable_pg_native_login` to the mock server's project response to match current backend behavior - Update golden files ## Test plan - [x] All 4 tests pass locally (both direct and terraform) - [x] All 4 tests pass on AWS cloud (direct); terraform has pre-existing provider issues unrelated to this PR This pull request was AI-assisted by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
primarytocustominpostgres_endpoints/basictest to avoid conflict with the auto-created primary endpointenable_pg_native_loginto the mock server's project response to match current backend behaviorTest plan
This pull request was AI-assisted by Isaac.