Skip to content

Fix Lakebase acceptance tests for backend changes #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-goenka merged 1 commit into from
Mar 16, 2026
Merged

Fix Lakebase acceptance tests for backend changes #4746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions acceptance/bundle/resources/postgres_endpoints/basic/databricks.yml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ resources:
no_expiry: true

postgres_endpoints:
primary:
custom:
parent: ${resources.postgres_branches.main.id}
endpoint_id: primary
endpoint_id: custom
endpoint_type: ENDPOINT_TYPE_READ_ONLY
autoscaling_limit_min_cu: 0.5
autoscaling_limit_max_cu: 2
6 changes: 3 additions & 3 deletions acceptance/bundle/resources/postgres_endpoints/basic/out.requests.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"method": "POST",
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints",
"q": {
"endpoint_id": "primary"
"endpoint_id": "custom"
},
"body": {
"spec": {
Expand All @@ -45,9 +45,9 @@
}
{
"method": "GET",
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/primary"
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/custom"
}
{
"method": "GET",
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/primary"
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/custom"
}
4 changes: 2 additions & 2 deletions acceptance/bundle/resources/postgres_endpoints/basic/out.requests.terraform.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"method": "POST",
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints",
"q": {
"endpoint_id": "primary"
"endpoint_id": "custom"
},
"body": {
"parent": "projects/test-pg-proj-[UNIQUE_NAME]/branches/main",
Expand All @@ -47,5 +47,5 @@
}
{
"method": "GET",
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/primary"
"path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/custom"
}
10 changes: 5 additions & 5 deletions acceptance/bundle/resources/postgres_endpoints/basic/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Resources:
Name:
URL: (not deployed)
Postgres endpoints:
primary:
custom:
Name:
URL: (not deployed)
Postgres projects:
Expand All @@ -34,9 +34,9 @@ Deploying resources...
Updating deployment state...
Deployment complete!

>>> [CLI] postgres get-endpoint projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/primary
>>> [CLI] postgres get-endpoint projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/custom
{
"name": "projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/primary",
"name": "projects/test-pg-proj-[UNIQUE_NAME]/branches/main/endpoints/custom",
"parent": "projects/test-pg-proj-[UNIQUE_NAME]/branches/main",
"status": {
"autoscaling_limit_max_cu": 2,
Expand Down Expand Up @@ -71,7 +71,7 @@ Resources:
Name:
URL: (not deployed)
Postgres endpoints:
primary:
custom:
Name:
URL: (not deployed)
Postgres projects:
Expand All @@ -84,7 +84,7 @@ Resources:
>>> [CLI] bundle destroy --auto-approve
The following resources will be deleted:
delete resources.postgres_branches.main
delete resources.postgres_endpoints.primary
delete resources.postgres_endpoints.custom
delete resources.postgres_projects.my_project

All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/deploy-postgres-endpoint-[UNIQUE_NAME]/default
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/postgres_endpoints/basic/script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ trace $CLI bundle deploy
# Get endpoint details
project_name="projects/test-pg-proj-${UNIQUE_NAME}"
branch_name="${project_name}/branches/main"
endpoint_name="${branch_name}/endpoints/primary"
endpoint_name="${branch_name}/endpoints/custom"
trace $CLI postgres get-endpoint "${endpoint_name}" | jq 'del(.create_time, .update_time)'

trace $CLI bundle summary
Expand Down
1 change: 1 addition & 0 deletions acceptance/bundle/resources/postgres_projects/basic/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Deployment complete!
"suspend_timeout_duration": "300s"
},
"display_name": "Test Postgres Project",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down
1 change: 1 addition & 0 deletions acceptance/bundle/resources/postgres_projects/recreate/out.get_project.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"suspend_timeout_duration":"300s"
},
"display_name":"Test Recreate",
"enable_pg_native_login":true,
"history_retention_duration":"604800s",
"owner":"[USERNAME]",
"pg_version":16,
Expand Down
1 change: 1 addition & 0 deletions ...nce/bundle/resources/postgres_projects/update_display_name/out.plan.no_change.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"suspend_timeout_duration": "300s"
},
"display_name": "Original Name",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down
1 change: 1 addition & 0 deletions ...tance/bundle/resources/postgres_projects/update_display_name/out.plan.restore.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"suspend_timeout_duration": "300s"
},
"display_name": "Updated Name",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down
1 change: 1 addition & 0 deletions ...ptance/bundle/resources/postgres_projects/update_display_name/out.plan.update.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"suspend_timeout_duration": "300s"
},
"display_name": "Original Name",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down
3 changes: 3 additions & 0 deletions acceptance/bundle/resources/postgres_projects/update_display_name/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Deployment complete!
"suspend_timeout_duration": "300s"
},
"display_name": "Original Name",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down Expand Up @@ -105,6 +106,7 @@ Deployment complete!
"suspend_timeout_duration": "300s"
},
"display_name": "Updated Name",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down Expand Up @@ -142,6 +144,7 @@ Deployment complete!
"suspend_timeout_duration": "300s"
},
"display_name": "Original Name",
"enable_pg_native_login": true,
"history_retention_duration": "604800s",
"owner": "[USERNAME]",
"pg_version": 16,
Expand Down
1 change: 1 addition & 0 deletions libs/testserver/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ func (s *FakeWorkspace) PostgresProjectCreate(req Request, projectID string) Res
DisplayName: project.Spec.DisplayName,
PgVersion: project.Spec.PgVersion,
HistoryRetentionDuration: project.Spec.HistoryRetentionDuration,
EnablePgNativeLogin: true,
Owner: TestUser.UserName,
BranchLogicalSizeLimitBytes: 8796093022208, // 8 TB (real API default)
SyntheticStorageSizeBytes: 0,
Expand Down
Loading