Bump AppKit to 0.23.0 and agent skills to 0.1.4#4968
Merged
Conversation
arsenyinfo
approved these changes
Apr 15, 2026
Contributor
arsenyinfo
left a comment
arsenyinfo
left a comment
There was a problem hiding this comment.
Tests with hardcoded version seem annoying to maintain btw
Member
Author
|
@arsenyinfo agree, not sure when they were added but I'll fix it here 👍 |
Co-authored-by: Isaac
Co-authored-by: Isaac
pkosiec
force-pushed
the
pkosiec/bump-appkit-and-skills
branch
from
9499d1f to
347139a
Compare
pietern
approved these changes
Apr 15, 2026
simonfaltum
approved these changes
Apr 15, 2026
4 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
## Why The `maintainer-approval` workflow uses `@databricks/eng-apps-devex` team references in OWNERS, then calls `teams.getMembershipForUserInOrg()` to check if a reviewer belongs to that team. This API requires `read:org` scope, which `GITHUB_TOKEN` doesn't support (it only has repository-scoped permissions). The API returns 404 for privacy reasons, the code silently treats that as "not a member", and team-based approvals never resolve. This showed up on #4968 where arsenyinfo (a member of eng-apps-devex) approved, but the check stayed pending until a maintainer stepped in. ## Changes We already have an `OWNERTEAMS` mechanism that expands `team:<name>` references to individual logins at parse time, no API calls needed. `team:bundle` and `team:platform` already use it. This PR adds `team:eng-apps-devex` to the same system: - OWNERTEAMS: added `team:eng-apps-devex` with the full team roster (12 members) - OWNERS: replaced all `@databricks/eng-apps-devex` references with `team:eng-apps-devex` - Tests: updated to use `OWNERTEAMS`-based team resolution instead of mocking the GitHub API ## Test plan - [x] All 20 existing maintainer-approval tests pass - [x] Team member approval now resolves via OWNERTEAMS expansion (no API dependency) - [x] Non-team-member approval correctly stays pending - [x] `make ws` passes This pull request was AI-assisted by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary