Move eng-apps-devex to OWNERTEAMS for approval resolution#4976
Merged
simonfaltum merged 2 commits intomainfrom Apr 15, 2026
Merged
Move eng-apps-devex to OWNERTEAMS for approval resolution#4976simonfaltum merged 2 commits intomainfrom
simonfaltum merged 2 commits intomainfrom
Conversation
…tion Co-authored-by: Isaac
Co-authored-by: Isaac
pietern
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
maintainer-approvalworkflow uses@databricks/eng-apps-devexteam references in OWNERS, then callsteams.getMembershipForUserInOrg()to check if a reviewer belongs to that team. This API requiresread:orgscope, whichGITHUB_TOKENdoesn't support (it only has repository-scoped permissions). The API returns 404 for privacy reasons, the code silently treats that as "not a member", and team-based approvals never resolve.This showed up on #4968 where arsenyinfo (a member of eng-apps-devex) approved, but the check stayed pending until a maintainer stepped in.
Changes
We already have an
OWNERTEAMSmechanism that expandsteam:<name>references to individual logins at parse time, no API calls needed.team:bundleandteam:platformalready use it. This PR addsteam:eng-apps-devexto the same system:team:eng-apps-devexwith the full team roster (12 members)@databricks/eng-apps-devexreferences withteam:eng-apps-devexOWNERTEAMS-based team resolution instead of mocking the GitHub APITest plan
make wspassesThis pull request was AI-assisted by Isaac.