internal: Allow absence of field to mean "all fields" in resource config#5849
Merged
Conversation
Collaborator
Integration test reportCommit: 78babbb
8 interesting tests: 4 SKIP, 2 RECOVERED, 2 flaky
Top 10 slowest tests (at least 2 minutes):
|
denik
changed the title
andrewnester
reviewed
Jul 8, 2026
| reason: immutable | ||
| - field: spec.type_overrides | ||
| reason: immutable | ||
| - reason: immutable |
Contributor
There was a problem hiding this comment.
What would happen if there are some fields with
- field: ...
reason: ...
syntax and then also one with ommited field? (let's say by mistake). Shall we error out in such cases and only allow empty field if there are no other entries?
Contributor
Author
There was a problem hiding this comment.
it's no different from adding two overlapping entries today: x and x.y. We don't validate.
We can validate, but it maybe more complex than this simple change. For example, we can also take into account absence of DoUpdate and maybe even make this configuration automatic.
andrewnester
approved these changes
Jul 8, 2026
pietern
approved these changes
Jul 8, 2026
radakam
added a commit
that referenced
this pull request
Jul 8, 2026
Since #5849 the field walk no longer skips the root node, so a root rule (omitted field) records the empty path "" and short-circuits the walk at the root on its own. The separate rootCovered flag and markCovered helper are no longer needed; inline the coverage assignment.
Collaborator
Integration test reportCommit: 1d8961e
35 interesting tests: 29 flaky, 3 KNOWN, 2 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for resources without update methods.
The provided_id_fields takes preference, so works as expected if field is in both.