acc: hard-fail when change detection diff fails#6057
Merged
Conversation
Collaborator
Integration test reportCommit: 67509e5
9 interesting tests: 4 RECOVERED, 4 SKIP, 1 flaky
Top 17 slowest tests (at least 2 minutes):
|
Revert the fail-open from #6047 now that every caller (push.yml PR cells and integration runs) fetches origin/main. A failed `git diff --merge-base origin/main` should abort loudly instead of silently disabling change detection and letting new tests skip.
denik
force-pushed
the
denik/change-detection-hard-fail
branch
from
July 24, 2026 10:07
de50f6b to
67509e5
Compare
denik
enabled auto-merge
July 24, 2026 10:37
janniklasrose
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #6047, which made
selectChangedLocalTestsfail open (log a warning and continue) whengit diff --merge-base origin/mainfails. Fail-open was a temporary concession so integration runs (DATABRICKS_TEST_SKIPLOCAL=withchanged) wouldn't break from a checkout without origin/main. Now that every caller fetches origin/main, a failed diff should abort loudly again — otherwise a missing origin/main silently disables change detection and lets newly added tests skip.Changes
selectChangedLocalTests: revert the
t.Logf+return nilback tot.Fatalf.Do not merge until the eng-dev-ecosystem integration workflow provides origin/main in the CLI checkout; otherwise integration runs will hard-fail again.