Move bundle/run.runPageURL to libs/workspaceurls - #6145
Merged
Conversation
The legacy-to-path run URL conversion is needed outside `bundle run`, so it moves to libs/workspaceurls next to JobRunPath, which it already used. Pure move: the conversion, its doc comment and its tests are unchanged.
The context only reached two debug lines about a URL that did not parse. Keeping it forces every caller to have a context on hand for a purely cosmetic string conversion.
radakam
marked this pull request as ready for review
August 3, 2026 12:25
Collaborator
Integration test reportCommit: 1556dbc
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
denik
approved these changes
Aug 3, 2026
radakam
changed the title
The name did not say what the function does with the URL it is given. It converts a legacy fragment-form run URL into the modern path form, so a verb makes the call sites read better.
radakam
enabled auto-merge
August 3, 2026 13:04
denik
changed the title
Collaborator
Integration test reportCommit: bc711c4
29 interesting tests: 19 flaky, 5 RECOVERED, 2 FAIL, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move the legacy-to-path run URL conversion from
bundle/run/job.gointolibs/workspaceurlsasJobRunPageURL, next to theJobRunPathhelper it already used. Tests move with it. Thectxparameter is dropped since it only fed two debug lines.Why
A second caller outside
bundle runneeds it: thejob_runsresource in #6091.Tests
Existing unit tests, moved unchanged apart from the dropped
ctx.