OWNERS: add team:ide and own the environments integration tests - #6184
Merged
rugpanov merged 2 commits intoAug 6, 2026
Merged
Conversation
Add @rugpanov, @rclarey, @anton-107 and @misha-db as owners of /integration/cmd/environments/, matching the existing ownership of /libs/localenv/, /cmd/environments/ and /acceptance/localenv/ so the DB Connect / setup-local tests are reviewed by the same people as the code they exercise. The rest of /integration/ stays with team:platform. The entry has to sit below the broader /integration/ rule: findOwners is last-match-wins, so placing it next to the other localenv lines earlier in the file would let team:platform override it. Verified both ways with findOwners before settling on this position.
rugpanov
changed the title
The four localenv paths each repeated the same list of four handles, so a roster change meant four edits that could silently drift apart. Define team:ide in OWNERTEAMS once and reference it from all of them, including the new /integration/cmd/environments/ entry. Ownership is unchanged: all four paths still resolve to @rugpanov, @rclarey, @anton-107 and @misha-db, verified with findOwners. No GitHub org team page yet, so the validator emits its non-blocking "no GitHub team-page URL" warning, same as team:ai-training. Creating the org team needs org-owner access; the alias works standalone in the meantime, which is how team:bundle and team:platform already operate (neither cli-maintainers nor cli-platform exists as an org team today).
rugpanov
force-pushed
the
grigory/owners-integration-environments
branch
from
August 6, 2026 08:56
b98b43e to
722c947
Compare
rugpanov
changed the title
Collaborator
Integration test reportCommit: 722c947
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Aug 6, 2026
rugpanov
added a commit
that referenced
this pull request
Aug 6, 2026
## Changes Two related changes to ownership of the DB Connect / local-environments code: 1. **Define `team:ide`** in `.github/OWNERTEAMS` — `@rugpanov @rclarey @anton-107 @misha-db`. 2. **Own `/integration/cmd/environments/`** so the `setup-local` integration tests are reviewed by the same people who own the code they exercise. The three existing localenv paths each repeated the same four handles, so a roster change meant four separate edits that could silently drift apart. They now reference the alias instead: ``` /libs/localenv/ team:ide /cmd/environments/ team:ide /acceptance/localenv/ team:ide /integration/cmd/environments/ team:ide # new ``` **Ownership is unchanged** for the three pre-existing paths — same four people, one source of truth. The rest of `/integration/` stays with `team:platform`. ### Why the new entry sits below `/integration/` `findOwners` is **last-match-wins**. Putting the new rule next to the other localenv lines (line ~17) looks natural but silently does nothing: the broader `/integration/ team:platform` rule at line 65 matches later and wins. My first attempt did exactly that, and `owners.js validate` passed anyway — the misplacement is invisible to the validator. Hence the position after `/integration/`, plus a comment so it doesn't get "tidied" back up. ### No GitHub org team yet There's no `github.com/orgs/databricks/teams/ide` page, so the validator emits its non-blocking `no GitHub team-page URL` warning — the same one `team:ai-training` already produces. Per `validateOwners`, this is by design: *"A team may legitimately predate its GitHub team page, so this never blocks a merge."* The alias is fully functional standalone, which is how the existing aliases already work — neither `cli-maintainers` nor `cli-platform` (both listed in the OWNERTEAMS header) exists as an org team today, and OWNERTEAMS is explicitly the source of truth because `GITHUB_TOKEN` can't resolve org team membership. Creating the real org team needs org-owner access; the header URL can be added later. ## Tests - `node .github/scripts/owners.js validate` → passes (2 non-blocking warnings: the new `team:ide` and the pre-existing `team:ai-training`). - `node --test .github/scripts/owners.test.js .github/workflows/maintainer-approval.test.js` → 64/64 pass. - Resolution verified with `findOwners`: | path | owners | | --- | --- | | `libs/localenv/uv.go` | `rugpanov rclarey anton-107 misha-db` (unchanged) | | `cmd/environments/setup_local.go` | `rugpanov rclarey anton-107 misha-db` (unchanged) | | `acceptance/localenv/…` | `rugpanov rclarey anton-107 misha-db` (unchanged) | | `integration/cmd/environments/setup_local_test.go` | `rugpanov rclarey anton-107 misha-db` ✅ new | | `integration/cmd/jobs/foo_test.go` | `team:platform` (unchanged) | ## Note on the base branch Based on `dbconnect/setup-local-integration` (#6155) rather than `main`, because `owners.js validate` errors on rules whose path doesn't exist in the tree, and `integration/cmd/environments/` is created by that PR. Once #6155 lands this can be retargeted to `main`. _This pull request and its description were written by Isaac._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Two related changes to ownership of the DB Connect / local-environments code:
team:idein.github/OWNERTEAMS—@rugpanov @rclarey @anton-107 @misha-db./integration/cmd/environments/so thesetup-localintegration tests are reviewed by the same people who own the code they exercise.The three existing localenv paths each repeated the same four handles, so a roster change meant four separate edits that could silently drift apart. They now reference the alias instead:
Ownership is unchanged for the three pre-existing paths — same four people, one source of truth. The rest of
/integration/stays withteam:platform.Why the new entry sits below
/integration/findOwnersis last-match-wins. Putting the new rule next to the other localenv lines (line ~17) looks natural but silently does nothing: the broader/integration/ team:platformrule at line 65 matches later and wins. My first attempt did exactly that, andowners.js validatepassed anyway — the misplacement is invisible to the validator. Hence the position after/integration/, plus a comment so it doesn't get "tidied" back up.No GitHub org team yet
There's no
github.com/orgs/databricks/teams/idepage, so the validator emits its non-blockingno GitHub team-page URLwarning — the same oneteam:ai-trainingalready produces. PervalidateOwners, this is by design: "A team may legitimately predate its GitHub team page, so this never blocks a merge."The alias is fully functional standalone, which is how the existing aliases already work — neither
cli-maintainersnorcli-platform(both listed in the OWNERTEAMS header) exists as an org team today, and OWNERTEAMS is explicitly the source of truth becauseGITHUB_TOKENcan't resolve org team membership. Creating the real org team needs org-owner access; the header URL can be added later.Tests
node .github/scripts/owners.js validate→ passes (2 non-blocking warnings: the newteam:ideand the pre-existingteam:ai-training).node --test .github/scripts/owners.test.js .github/workflows/maintainer-approval.test.js→ 64/64 pass.findOwners:libs/localenv/uv.gorugpanov rclarey anton-107 misha-db(unchanged)cmd/environments/setup_local.gorugpanov rclarey anton-107 misha-db(unchanged)acceptance/localenv/…rugpanov rclarey anton-107 misha-db(unchanged)integration/cmd/environments/setup_local_test.gorugpanov rclarey anton-107 misha-db✅ newintegration/cmd/jobs/foo_test.goteam:platform(unchanged)Note on the base branch
Based on
dbconnect/setup-local-integration(#6155) rather thanmain, becauseowners.js validateerrors on rules whose path doesn't exist in the tree, andintegration/cmd/environments/is created by that PR. Once #6155 lands this can be retargeted tomain.This pull request and its description were written by Isaac.