Skip to content

Fix coverage reporting in CI#173

Merged
nithinkdb merged 4 commits intomainfrom
fix-ci-coverage
Sep 10, 2023
Merged

Fix coverage reporting in CI#173
nithinkdb merged 4 commits intomainfrom
fix-ci-coverage

Conversation

@kravets-levko
Copy link
Copy Markdown
Contributor

@kravets-levko kravets-levko commented Sep 9, 2023

Follow up on #172

Since we've split unit and e2e jobs, codecov stopped seing the full coverage report. So now we store coverage reports after unit and e2e jobs, and unpack them when running coverage job so it can process both

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 12:57 — with GitHub Actions Inactive
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 13:04 — with GitHub Actions Inactive
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 13:05 — with GitHub Actions Inactive
@databricks databricks deleted a comment from github-actions Bot Sep 9, 2023
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 13:09 — with GitHub Actions Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 13:14 — with GitHub Actions Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 13:23 — with GitHub Actions Inactive
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko kravets-levko temporarily deployed to azure-prod September 9, 2023 13:29 — with GitHub Actions Inactive
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@nithinkdb nithinkdb merged commit d3a8d4a into main Sep 10, 2023
@kravets-levko kravets-levko deleted the fix-ci-coverage branch September 10, 2023 05:58
nithinkdb pushed a commit that referenced this pull request Sep 12, 2023
* Fix coverage reporting in CI

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Fix commands

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Fix codecov job

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Fix codecov job

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

---------

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
kravets-levko added a commit that referenced this pull request Sep 14, 2023
* Fix coverage reporting in CI (#173)

* Fix coverage reporting in CI

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Fix commands

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Fix codecov job

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Fix codecov job

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

---------

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>

* Removed runAsync option

Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>

* Linted

Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>

* Remove runAsync leftovers

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

* Deprecate runAsync option

Signed-off-by: Levko Kravets <levko.ne@gmail.com>

---------

Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Co-authored-by: Levko Kravets <levko.ne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants