Refactoring: Convert global config to client config and make it available through client context#202
Merged
kravets-levko merged 3 commits intomainfrom Nov 14, 2023
Merged
Conversation
…client context Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levko
requested review from
andrefurlan-db,
arikfr,
nithinkdb,
superdupershant,
susodapop and
yunbodeng-db
as code owners
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 88.34% 88.38% +0.04%
==========================================
Files 58 57 -1
Lines 1304 1309 +5
Branches 208 208
==========================================
+ Hits 1152 1157 +5
Misses 105 105
Partials 47 47 ☔ View full report in Codecov by Sentry. |
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
kravets-levko
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used global config as a container for feature flags. It wasn't the best possible solution at the time we introduced it, but it did its job. Now, when we have a client context, it's time to make those configuration a part of it
Note for reviewers: most changes are made in test files. No changes to tests logic, just global config usages replaced with proper mocks for client context