ci: make fork offline CI robust — 3.9 skip, mypy flags, warmer matrix (#831)#851
Merged
Merged
Conversation
…#831) Follow-ups from the fork verification run (#849) once the cache finally hit. The offline restore mechanism works (10 legs green offline incl. all kernel legs); these fix the remaining offline-path failures: 1. Python 3.9 can't be provisioned offline — the protected-runner image preinstalls 3.10-3.14 but not 3.9 (EOL), so setup-python tries to DOWNLOAD it and fails with no network on a fork. That hard-failed the 3.9 legs and, under fail-fast, cancelled the working 3.10-3.14 siblings. Move setup-python into restore-deps with continue-on-error, probe the restored interpreter, and export venv-usable; callers gate their offline run on it and skip 3.9 neutrally (3.9 fork coverage is in the merge queue) instead of failing. Keeps 3.9 in the matrix per maintainer preference without letting it sink the other legs. 2. check-types offline ran , which mypy rejects without --install-types ('--non-interactive is only supported with --install-types'). The warmer already primed the stubs into the venv, so run plain . 3. The warmer excluded 3.14-min but the PR matrix runs 3.14-min pyarrow (PR excludes only 3.12-min/3.13-min) — that leg missed the cache and fell back to JFrog. Align the warmer's excludes to the PR matrix exactly. Refs #831 Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
vikrantpuppala
added a commit
to vikrantpuppala/databricks-sql-python
that referenced
this pull request
Jul 9, 2026
…warmed) (databricks#831) Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the fork verification run (#849) after the cache finally hit (#850 fixed the key mismatch). The offline restore mechanism works — 10 legs ran green offline, including all 5 kernel legs and
check-linting3.10–3.14. This PR fixes the three remaining offline-path failures the run surfaced:Python 3.9 can't be provisioned offline. The protected-runner image preinstalls 3.10–3.14 but not 3.9 (EOL), so
actions/setup-pythontries to download 3.9 and fails with no network on a fork. That hard-failed the 3.9 legs and — underfail-fast— cancelled the working 3.10–3.14 siblings. Fix: movesetup-pythonintorestore-depswithcontinue-on-error, probe the restored interpreter, and exportvenv-usable. Callers gate their offline run onvenv-usable=='true'and skip 3.9 neutrally (3.9 fork coverage is in the merge queue) instead of failing. Keeps 3.9 in the matrix (per maintainer preference) without letting it sink the other legs.check-typesoffline ranmypy --non-interactive src, which mypy rejects without--install-types(--non-interactive is only supported with --install-types). The warmer already primed the stubs into the venv, so run plainmypy src.Warmer matrix mismatch. The warmer excluded
3.14-minbut the PR matrix runs3.14-minpyarrow (PR excludes only3.12-min/3.13-min) — that leg missed the cache and fell back to JFrog. Align the warmer's excludes to the PR matrix exactly.Test plan
main(seeds3.14-mintoo), then re-run fork PR test: verify fork-PR CI runs offline from prewarmed cache (#831) [DO NOT MERGE] #849 → expect all legs green offline except 3.9, which skips neutrally.Refs #831
This pull request and its description were written by Isaac.