Gate strict std.format boolean conversions behind a flag - #1069
Merged
stephenamar-db merged 1 commit intoJun 30, 2026
Conversation
Motivation: PR databricks#1053 reverted the previous std.format boolean conversion change because default behavior must remain compatible. The maintainer asked for a roll-forward with the new behavior behind a flag. Modification: Add Settings.strictFormatBooleanConversions and CLI --strict-format-boolean-conversions. Route std.format/% boolean handling through that setting so the default continues to coerce true/false to 1/0 while the flag rejects boolean values for numeric conversions and still allows %s. Result: Default std.format behavior remains unchanged. Users can opt in to stricter boolean numeric conversion errors, with evaluator and CLI tests covering both paths. References: databricks#1053
stephenamar-db
approved these changes
Jun 30, 2026
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #1053 reverted the stricter
std.formatboolean conversion behavior so the default can remain compatible with current master. The maintainer asked for a roll-forward with the new behavior behind a flag.Modification
Add
Settings.strictFormatBooleanConversionswith defaultfalseand expose it through the CLI flag--strict-format-boolean-conversions. Routestd.formatboolean handling through that setting so default behavior continues coercingtrue/falseto1/0, while opt-in strict mode rejects booleans for numeric conversion codes and still allows%s.Result
'%d' % true"1""1"'%s' % true"true""true""true""true""true"References