fix(basket): correct geo resolution telemetry + drop redis geoip cache by izadoesdev · Pull Request #589 · databuddy-analytics/Databuddy

izadoesdev · 2026-08-04T11:50:17Z

What

Two slices fixing the basket IP-geo pipeline.

1. Geo resolution telemetry blind spot (`fix`)

The Axiom geo dashboard showed 0.4% resolution / 17.1M "failed to locate" — a measurement artifact, not an outage. getGeo() only merged a geo.* wide-event field on the Cloudflare-fallback and skipped-IP paths. On the MaxMind success path (~99.5% of traffic) it returned the country but never logged it, so Axiom recorded geo.country = null and the dashboard read those as failures.

Evidence (7d, basket dataset): geo.source=cloudflare_header = 76,957 = exactly the "resolved" count; zero GeoIP load errors; MaxMind lookups run on all 17.18M events at 0.26ms p50; flat 30-day trend with no cliff.

Fix: every request now emits a geo.source — maxmind / cloudflare_header / unresolved / skipped.

2. Drop the Redis GeoIP cache (`perf`)

timing.getGeo p50 was 142ms while the in-memory MaxMind lookup is 0.26ms — the cacheable Redis wrapper was ~500x slower than the value it cached. Removed the cache and the /24 coarsenIpForCache helper; lookups now hit the in-process reader on the full IP, restoring city/region precision the coarsening discarded.

Test

bun test src/utils/ip-geo.test.ts -> 20 pass; check-types green across all packages.

Follow-up (dashboard owner)

Update the Axiom panels to compute resolution from geo.source (maxmind + cloudflare_header = resolved) instead of isnull(geo.country).

Summary by cubic

Fixes geo resolution telemetry by always emitting geo.source, and removes the Redis GeoIP cache to use the in-process MaxMind lookup. This corrects false “failed to locate” readings in Axiom and cuts lookup p50 from ~142ms to ~0.26ms while restoring city/region precision.

Migration
- Update Axiom dashboards to compute resolution from geo.source (maxmind + cloudflare_header = resolved) instead of isnull(geo.country).

^{Written for commit 1aa2b32. Summary will update on new commits.}

…ookup

cursor · 2026-08-04T11:50:23Z

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

vercel · 2026-08-04T11:50:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
databuddy-status	Ready	Preview	Aug 4, 2026 11:50am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
dashboard	Skipped		Aug 4, 2026 11:50am
documentation	Skipped		Aug 4, 2026 11:50am

unkey-deploy · 2026-08-04T11:50:25Z

The latest updates on your projects. Learn more about Unkey Deploy

Name	Status	Preview	Inspect	Updated (UTC)
links (preview)	Ready	Visit Preview	Inspect	Aug 4, 2026 11:50am

coderabbitai · 2026-08-04T11:50:26Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c3e6260e-0d96-4485-a6e5-310b54661845

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

dosubot · 2026-08-04T11:50:28Z

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.

greptile-apps · 2026-08-04T11:52:57Z

Greptile Summary

This PR removes Redis-backed, coarsened-IP GeoIP caching in favor of direct full-IP MaxMind lookups and adds resolution-source telemetry.

Records MaxMind and unresolved outcomes in the request-wide event.
Preserves Cloudflare country fallback while restoring full-IP region and city precision.
Leaves the skipped-IP branch without the promised geo.source value and broadens precise-location telemetry.

Confidence Score: 4/5

The skipped-IP telemetry defect should be fixed before merging so the promised source-based accounting covers every request; precise city and region logging should also be reconsidered.

The primary telemetry correction remains incomplete because the early skipped-IP return emits no source, while the MaxMind branch additionally broadens precise user-location data sent to operational telemetry.

Files Needing Attention: apps/basket/src/utils/ip-geo.ts

Important Files Changed

Filename	Overview
apps/basket/src/utils/ip-geo.ts	Removes Redis/coarsened lookup caching and adds MaxMind telemetry, but skipped IPs still lack `geo.source` and the new merge unnecessarily expands city/region observability.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[getGeo receives client IP] --> B{Invalid or local IP?}
  B -- Yes --> C[Emit skipped metadata and return]
  B -- No --> D[Direct MaxMind lookup using full IP]
  D --> E{Country resolved?}
  E -- Yes --> F[Emit source=maxmind and geo fields]
  E -- No --> G{Cloudflare country header?}
  G -- Yes --> H[Emit source=cloudflare_header]
  G -- No --> I[Emit source=unresolved]

Comments Outside Diff (1)

apps/basket/src/utils/ip-geo.ts, line 185-187 (link)

Skipped source remains unreported

When an IP is empty, malformed, or local, this early return records only skipped and reason, leaving geo.source unset and preventing the source-based dashboard from accounting for these requests as skipped.

Knowledge Base Used: Basket Ingestion Flow

_{Reviews (1): Last reviewed commit: "perf(basket): drop redis geoip cache in ..." | Re-trigger Greptile}

greptile-apps · 2026-08-04T11:53:09Z

+		mergeWideEvent({
+			geo: geo.country
+				? {
+						source: "maxmind",
+						country: geo.country,
+						region: geo.region,
+						city: geo.city,
+					}
+				: { source: "unresolved" },
+		});


Telemetry expands precise geo data

The new MaxMind merge sends user-derived city and region data to operational telemetry even for callers that never persist an analytics event. These fields are unnecessary for measuring resolution source and broaden the retention and audience exposure of precise location data.

Suggested change

mergeWideEvent({

geo: geo.country

? {

source: "maxmind",

country: geo.country,

region: geo.region,

city: geo.city,

}

: { source: "unresolved" },

});

mergeWideEvent({

geo: geo.country

? {

source: "maxmind",

country: geo.country,

}

: { source: "unresolved" },

});

Knowledge Base Used: Basket Ingestion Flow

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

izadoesdev added 2 commits August 4, 2026 14:48

fix(basket): log geo resolution source on maxmind and unresolved paths

9230dc0

perf(basket): drop redis geoip cache in favor of in-process maxmind l…

1aa2b32

…ookup

unkey-deploy Bot deployed to links - preview August 4, 2026 11:50 View deployment

vercel Bot deployed to Preview – databuddy-status August 4, 2026 11:50 View deployment

izadoesdev merged commit d80410d into staging Aug 4, 2026
19 checks passed

izadoesdev deleted the izadoesdev/basket-geo-telemetry branch August 4, 2026 11:51

greptile-apps Bot reviewed Aug 4, 2026

View reviewed changes

izadoesdev mentioned this pull request Aug 4, 2026

fix(basket): stop logging expected conditions as errors in Axiom #590

Merged

Navigation Menu

Uh oh!

fix(basket): correct geo resolution telemetry + drop redis geoip cache - #589

fix(basket): correct geo resolution telemetry + drop redis geoip cache#589
izadoesdev merged 2 commits into
stagingfrom
izadoesdev/basket-geo-telemetry

izadoesdev commented Aug 4, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

cursor Bot commented Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

unkey-deploy Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 4, 2026

Review skipped

Uh oh!

dosubot Bot commented Aug 4, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 4, 2026 •

edited

Loading

Comments Outside Diff (1)

Uh oh!

greptile-apps Bot Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

izadoesdev commented Aug 4, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

1. Geo resolution telemetry blind spot (fix)

2. Drop the Redis GeoIP cache (perf)

Test

Follow-up (dashboard owner)

Summary by cubic

Uh oh!

cursor Bot commented Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

unkey-deploy Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 4, 2026

Review skipped

Uh oh!

dosubot Bot commented Aug 4, 2026

📄 Knowledge review

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Flowchart

Comments Outside Diff (1)

Uh oh!

greptile-apps Bot Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

izadoesdev commented Aug 4, 2026 •

edited by cubic-dev-ai Bot

Loading

1. Geo resolution telemetry blind spot (`fix`)

2. Drop the Redis GeoIP cache (`perf`)

vercel Bot commented Aug 4, 2026 •

edited

Loading

unkey-deploy Bot commented Aug 4, 2026 •

edited

Loading

greptile-apps Bot commented Aug 4, 2026 •

edited

Loading