Fix test function highlight *decision needed*#167
Merged
Conversation
machow
changed the title
filipsch
approved these changes
Dec 2, 2016
Contributor
filipsch
left a comment
filipsch
left a comment
There was a problem hiding this comment.
Let's accept this as a temporary fix for the highlighting (so that it doesn't incorrectly highlight anymore), but I think just doing away with highlighting for test_function altogether would be a step backwards. test_function is used so incredibly often, and it would be a waste if we don't exploits Python's ast!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables highlighting by default for test function, but allows it to be re-enabled by setting highlight = True in test_function[_v2]. If that doesn't sit well with you, we can always set the default to True and weigh the problem more carefully.
The problem with highlighting when there is only 1 match, is that when there are 2 functions students should write, and they omit 1, it may highlight the wrong function. I'm not totally sold on either approach though.