Conversation
Contributor
|
@machow I retriggered the build on jenkins. |
Contributor
Author
|
Thanks! Started the validator. I added an issue detailing one of the limitations of override (#182) |
filipsch
approved these changes
Jan 5, 2017
Contributor
filipsch
left a comment
filipsch
left a comment
There was a problem hiding this comment.
Great feature with very little code, i like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note that this branch has not been built on Jenkins (initially wouldn't build, Maarten restarted Jenkins, and now it has been trying to build for over an hour?).
This PR introduces ~60 new unit tests for override (they are created using
setattrto create the tests on a Test class).I also fixed a weird AST thing with the body of lambda nodes being put inside a module.