Conversation
filipsch
reviewed
Jun 21, 2017
| elif type(f) == Chain: | ||
| raise BaseException("did you use a result of the Ex() function on the right hand side of the + operator?") | ||
| elif not callable(f): | ||
| raise BaseException("right hand side of + operator should be an SCT, so must be callable!") |
filipsch
reviewed
Jun 21, 2017
| if self._waiting_on_call: | ||
| self._double_attr_error() | ||
| elif type(f) == Chain: | ||
| raise BaseException("did you use a result of the Ex() function on the right hand side of the + operator?") |
filipsch
reviewed
Jun 21, 2017
Contributor
filipsch
left a comment
filipsch
left a comment
There was a problem hiding this comment.
Maybe some typos in the messages; other than that all good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements features used in sqlwhat necessary for pythonwhat-ext!