Skip to content

[CT-3468] - bb/return total package count as header of {GET} /api/packages#490

Merged
ben-brooker merged 1 commit intomasterfrom
bb/package-count
Jun 24, 2022
Merged

[CT-3468] - bb/return total package count as header of {GET} /api/packages#490
ben-brooker merged 1 commit intomasterfrom
bb/package-count

Conversation

@ben-brooker
Copy link
Copy Markdown
Contributor

@ben-brooker ben-brooker commented Jun 23, 2022

TICKET

  • Returns total package count as 'x-total-count' header of {GET} /api/packages.
  • Originally, I created an endpoint for the total package count ({GET} /api/packages) but this could potentially cause conflicts with the endpoint ({GET} /api/packages/:name) so I decided to return the count as a header of ({GET} /api/packages).

@ben-brooker ben-brooker changed the title [CT-3468] - bb/package-count [CT-3468] - bb/return total package count as header of {GET} /api/packages Jun 24, 2022
@filipsch
Copy link
Copy Markdown
Contributor

So would you need to fetch all packages in RDocumentation just to get the count? That feels very inefficient.

Copy link
Copy Markdown
Contributor

@ztsorojev ztsorojev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@ben-brooker ben-brooker merged commit e30f4f3 into master Jun 24, 2022
@ben-brooker ben-brooker deleted the bb/package-count branch June 24, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants