changing away from image as variable name #259
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR addresses #258. |
mkcor
reviewed
Mar 27, 2023
| > > | ||
| > > # load and display original image | ||
| > > image = iio.imread(uri="data/maize-root-cluster.jpg") | ||
| > > root = iio.imread(uri="data/maize-root-cluster.jpg") |
| > > import imageio.v3 | ||
| > > | ||
| > > image = iio.imread(uri="data/sudoku.jpg", mode="L") | ||
| > > sodoku = iio.imread(uri="data/sudoku.png") |
Contributor
There was a problem hiding this comment.
This was updated in PR #253 (hence the conflict). Would you mind merging gh-pages to sync up your branch? Thanks!
uschille
added
the
status:waiting for response
uschille
reviewed
Apr 12, 2023
Comment on lines
+199
to
+200
| eight_tiff = iio.imread(uri="data/eight.tif") | ||
| plt.imshow(eight_tiff) |
Contributor
There was a problem hiding this comment.
Suggested change
| eight_tiff = iio.imread(uri="data/eight.tif") | |
| plt.imshow(eight_tiff) | |
| eight = iio.imread(uri="data/eight.tif") | |
| plt.imshow(eight) |
Comment on lines
+229
to
+230
| print(eight_tiff.shape) | ||
| print(eight_tiff) |
Contributor
There was a problem hiding this comment.
Suggested change
| print(eight_tiff.shape) | |
| print(eight_tiff) | |
| print(eight.shape) | |
| print(eight) |
| > > # display images | ||
| > > fig, ax = plt.subplots() | ||
| > > plt.imshow(image) | ||
| > > plt.imshow(chair_jpg) |
Contributor
There was a problem hiding this comment.
I would suggest to use chair instead of chair_jpg.
| {: .language-python} | ||
| The NumPy command to ignore all low-intensity pixels is `image[image < 128] = 0`. | ||
| The NumPy command to ignore all low-intensity pixels is `roots[roots < 128] = 0`. |
Contributor
There was a problem hiding this comment.
I would suggest maize_roots instead of roots (roots could be confused with the mathematical sense, e.g., roots of an equation).
Member
|
Closing this one in favour of #265, which has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes places in episides 2 and 3 where the image variable name was image. Additionally, it corrects for refering to the sodoku image as a jpg although it is a png, and uses picture.copy() after creating certain images so they can be properly accessed (without this the accessing can create :ValueError: assignment destination is read-only)