Rename image variables to avoid name clashes #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhodges
approved these changes
Apr 14, 2023
Member
tobyhodges
left a comment
tobyhodges
left a comment
There was a problem hiding this comment.
This is excellent, @uschille, thank you 🙌
|
|
||
| * The possibility of executing the code cells in a notebook in arbitrary order can cause confusion. Using the "restart kernel and run all cells" feature is one way to accomplish linear execution of the notebook and may help to locate and identify coding issues. | ||
|
|
||
| * Many episodes in this lesson load image files from disk. To avoid name clashes in episodes that load multiple different files, we have used unique variable names (instead of generic names such as `image` or `img`). When copying code snippets between exercises, the variable names may have to be changed. The maintainers are keen to receive feedback whether this convention proves practical in workshops. |
Member
There was a problem hiding this comment.
Love this explanation, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #258 where @tobyhodges suggested:
This PR would benefit from a critical look by a couple of eyes. It includes contributions from @drcandacemakedamoore and supersedes #259.
Inspired by @bobturneruk's code extraction script, I have written a rudimentary script to check the Python code in the epsiodes which turned out to be quite handy. Maybe one day I'll add this to the Makefile...