Skip to content

Remove dependency on pandas#105

Merged
shifucun merged 2 commits intodatacommonsorg:masterfrom
shifucun:cache
Nov 5, 2019
Merged

Remove dependency on pandas#105
shifucun merged 2 commits intodatacommonsorg:masterfrom
shifucun:cache

Conversation

@shifucun
Copy link
Copy Markdown
Contributor

@shifucun shifucun commented Nov 5, 2019

No description provided.

Copy link
Copy Markdown
Contributor

@antaresc antaresc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, otherwise looks good. Thanks!

Comment thread datacommons/populations.py Outdated
if isinstance(dcids, pd.Series):
flattened = utils._flatten_results(result, default_value="")
return pd.Series([flattened[dcid] for dcid in dcids], index=dcids.index)
print(result)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these print statements be removed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shifucun shifucun merged commit 043abe8 into datacommonsorg:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants