Add get_stats endpoint.#123
Merged
shifucun merged 7 commits intodatacommonsorg:masterfrom Apr 24, 2020
Merged
Conversation
pradh
reviewed
Apr 24, 2020
| related_places = dc.get_related_places(['geoId/06085'], 'Person', 'count', | ||
| 'CenusACS5yrSurvey', "measuredValue", {"gender": "Female"}) | ||
| print(related_places) | ||
| # print('Get related places') |
Contributor
Author
There was a problem hiding this comment.
It was broken on current master, I've added a TODO.
pradh
reviewed
Apr 24, 2020
| in `Arkansas <https://browser.datacommons.org/kg?dcid=geoId/05>`_ | ||
| and `California <https://browser.datacommons.org/kg?dcid=geoId/06>`_. | ||
|
|
||
| >>> get_stats(["geoId/05", "geoId/06"], "dc/0hyp6tkn18vcb") |
Contributor
There was a problem hiding this comment.
Mahesh says the rollout is complete, could you use a human-curated DCID in this example?
(Adding a TODO in this PR is fine, if it needs more work.)
shifucun
approved these changes
Apr 24, 2020
pradh
reviewed
Apr 24, 2020
| self.assertDictEqual(bad_dcids_1, { | ||
| 'geoId/06085': ['geoId/0649670'], | ||
| 'dc/MadDcid': [] | ||
| }) |
Contributor
There was a problem hiding this comment.
I'm puzzled by the checks. Why don't the expected dict contain time-series?
Also s/get_places_in/get_stats/
Contributor
Author
There was a problem hiding this comment.
Sorry, I prematurely requested your review. Was having trouble testing locally so Bo had me create a PR for test to run on CloudRun, shouldn't have requested, though.
This should be fixed now, but need to see test results.
pradh
approved these changes
Apr 24, 2020
pradh
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.