Add pandas helper functions for get_stat_* #144
Conversation
…pd input function.
…tly double quoted.
beets
left a comment
beets
left a comment
There was a problem hiding this comment.
I have some meta questions around how we're structuring this library, as well as whether we should do the selection to cover most geos in this library or in the mixer (my vote for the latter, so that we get standardized behavior across clients).
…ll_by_obs_options.
…cpandas to datacommons_pandas.
beets
left a comment
beets
left a comment
There was a problem hiding this comment.
thanks, agree with the meta-changes you outlined. some outstanding comments still in df_builder.py
|
The structure looks much cleaner now! |
beets
left a comment
beets
left a comment
There was a problem hiding this comment.
thanks for the investigation, i think this solution works well!
i still have some unaddressed comments on df_builder.py (they seem to have gotten collapsed). could you take a look at those? mostly around readability and reusability of the selection logic.
…lder; add test for raising no data error; fix various tests that were returning the type HTTPError instead of an instance of HTTPError.
beets
left a comment
beets
left a comment
There was a problem hiding this comment.
thanks for making all the changes!
3 participants
No description provided.