Remove deprecated population and observation code#176
Merged
shifucun merged 2 commits intodatacommonsorg:masterfrom Mar 1, 2022
Merged
Remove deprecated population and observation code#176shifucun merged 2 commits intodatacommonsorg:masterfrom
shifucun merged 2 commits intodatacommonsorg:masterfrom
Conversation
beets
approved these changes
Mar 1, 2022
Contributor
beets
left a comment
beets
left a comment
There was a problem hiding this comment.
thanks for the update!
another thing we should look into is setting up continuous testing for our libraries so we can catch these earlier.
README.md
Outdated
| @@ -19,7 +18,7 @@ add the following line to your code: | |||
|
|
|||
| dc.set_api_key('YOUR-API-KEY') | |||
Contributor
There was a problem hiding this comment.
Should we just remove the note about the api key? We've removed it from the rest of our documentation (and the link on line 16 is a 404..)
Contributor
Author
There was a problem hiding this comment.
Removed API key section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External users still try to access the get_observations API which has been deprecated a long time ago.
Later on we should consider make the code more Python 3 compatible (or deprecate Python 2 support) and update all documentations to reflect recent changes.