Update Sparql query API to Python3 #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beets
reviewed
Nov 4, 2022
Contributor
beets
left a comment
beets
left a comment
There was a problem hiding this comment.
cool!
should we keep the "query" modules (rather than renaming to sparql) for consistency with the REST endpoint?
datacommons/sparql.py
Outdated
|
|
||
| Args: | ||
| query_string (:obj:`str`): The SPARQL query string. | ||
| select (:obj:`func` accepting a row in the query result): A function that |
Contributor
There was a problem hiding this comment.
Suggested change
| select (:obj:`func` accepting a row in the query result): A function that | |
| select (:obj:`func` accepting a row of the query result): A function that |
datacommons/sparql.py
Outdated
| query_string (:obj:`str`): The SPARQL query string. | ||
| select (:obj:`func` accepting a row in the query result): A function that | ||
| selects rows to be returned by :code:`query`. This function accepts a row | ||
| in the results of executing :code:`query_string` and return True if and |
Contributor
There was a problem hiding this comment.
Suggested change
| in the results of executing :code:`query_string` and return True if and | |
| of the result of executing :code:`query_string` and returns True if and |
Contributor
Author
Right now there is a module "query" which has a function "query". The library re-export the function in init.py: This is more of an internal change and users will still use "dc.query". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated test for setting API key; Some format change.