Re-enable place-resolution tests with current Spanner results - #712
Merged
rohitkumarbhagat merged 6 commits intoAug 5, 2026
Merged
Conversation
…ding Spanner data availability
…scription updates
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request temporarily disables or updates several test assertions in CoordinatesResolverTest, ExternalIdResolverTest, NameResolverTest, and ReconClientTest due to issues with Spanner S2 containment data and description resolution. These changes are marked with TODO comments to restore or re-enable the original assertions once the underlying data issues are resolved. As there are no review comments, I have no feedback to provide.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
… tests fix: align coordinate resolution tests with Spanner - Replace the unresolved San Francisco city point with one resolving to San Francisco County (geoId/06075) - update 53,-127 to Central Coast Regional District (wikidataId/Q1053752) - update 43,-116 to Owyhee County (geoId/16073) - reason : current Spanner containment returns these correct, more-specific places, - re-enable the integration tests.
test: use San Francisco County in coordinate resolution - Replaced SF city coordinates because their Spanner S2 cell lacks containment data; county coordinates resolve to geoId/06075. - Re-enable resolver assertions and retain coverage that candidates include country/USA.
rohitkumarbhagat
changed the title
rohitkumarbhagat
marked this pull request as ready for review
August 5, 2026 08:20
Contributor
|
Thanks Rohit for looking into it! |
vish-cs
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Place and DCID changes
San Francisco city → San Francisco County
37.77493,-122.41942/geoId/0667000with37.7395,-122.4014/geoId/06075.CoordinatesResolverTestverifies that the selected result isgeoId/06075, whileReconClientTestretains coverage that the candidates includecountry/USA.Canada → Central Coast Regional District
53,-127fromcountry/CANtowikidataId/Q1053752.Elmore County → Owyhee County
43,-116fromgeoId/16039togeoId/16073.Big Ben NUTS region → United Kingdom
51.510357,-0.116773fromnuts/UKI32tocountry/GBR.nuts/UKI32after the Spanner containment data is fixed.Mountain View description resolution
geoId/0649670.Related Mixer ordering fix: datacommonsorg/mixer#2083
Tests re-enabled
CoordinatesResolverTestExternalIdResolverTestNameResolverTestPropertyResolverTestReconClientTestMcfCheckerTestGenMcfTestLintTest