Fix chat upload filename code injection - #821
Merged
Merged
Conversation
yaojin3616
marked this pull request as ready for review
August 7, 2026 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
python3 -cextraction for PDF, DOCX, XLSX, and XLS uploads with the in-process trusted document extractor.Root cause
/api/chat/uploadinterpolated the uploaded path into Python source passed to a child process. A filename containing Python syntax could alter that source and execute in the backend process.Validation
PYTHONPATH="$PWD" uv run ruff check app/api/upload.py tests/test_upload_api.pyPYTHONPATH="$PWD" uv run pytest tests/test_upload_api.py(4 passed)Fixes Multica issue AND-149.