Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

@cfernhout
Copy link
Collaborator

Basic setup for automatically testing unit tests on two versions of Python (3.7 & 3.10). Interestingly, some unit tests fail for Python 3.7.

@linear
Copy link

linear bot commented May 13, 2022

DAT-3282 Set up CI

Why and what

Supporting material (links, screenshots, documents, logs, stacktraces)

.

@cfernhout cfernhout requested review from erezsh and sirupsen May 13, 2022 12:33
Copy link
Contributor

@sirupsen sirupsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfernhout sorry I was super unclear on Slack. Code here LGTM, I think my question for whether we should do more checks is basically: How much longer do I have to wait? How much more flaky is it likely to be?

I would love CI to pass in 2min for everything. If it takes much longer, I think we can peel some of these versions/OS combinations off, at your discretion

@cfernhout
Copy link
Collaborator Author

@sirupsen For now having a matrix of 4 iterations will run almost always in parallel. Only if the number of jobs explode (approx > 10) then you will get to the point that there is a chance that you need to wait on machines to become available. For now, everything runs quickly.

Copy link
Contributor

@sirupsen sirupsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM

@erezsh CI is failing because the Literal type wasn't introduced until Python 3.8. Can we replace it with something else, or do you think we should bump the minimum version?

@cfernhout cfernhout merged commit 7b2926a into master May 13, 2022
@cfernhout cfernhout deleted the chiel-dat-3282-set-up-ci branch May 13, 2022 14:26
nolar pushed a commit that referenced this pull request Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants