-
Notifications
You must be signed in to change notification settings - Fork 298
Chiel dat 3282 set up ci #25
Conversation
DAT-3282 Set up CI
Why and what Supporting material (links, screenshots, documents, logs, stacktraces) . |
sirupsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cfernhout sorry I was super unclear on Slack. Code here LGTM, I think my question for whether we should do more checks is basically: How much longer do I have to wait? How much more flaky is it likely to be?
I would love CI to pass in 2min for everything. If it takes much longer, I think we can peel some of these versions/OS combinations off, at your discretion
|
@sirupsen For now having a matrix of 4 iterations will run almost always in parallel. Only if the number of jobs explode (approx > 10) then you will get to the point that there is a chance that you need to wait on machines to become available. For now, everything runs quickly. |
sirupsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, LGTM
@erezsh CI is failing because the Literal type wasn't introduced until Python 3.8. Can we replace it with something else, or do you think we should bump the minimum version?
Basic setup for automatically testing unit tests on two versions of Python (3.7 & 3.10). Interestingly, some unit tests fail for Python 3.7.