Version 1.4.0 (renamed to v2.0.0)#29
Conversation
mkllnk
left a comment
There was a problem hiding this comment.
It's good to see that most changes are just additions to the code. So there's a lot of compatibility with older versions. But we can't parse a typical 1.16 document with our 2.0 context. For example, we currently use SuppliedProduct#isVariantOf which would fail to parse with v2 context. Similarly, if we publish data with the new Variant type then v1 platforms won't understand it. If they use a cached context then parsing will fail and they can't even use the compatible data. I think that we need to use explicit version numbers for the context. And we can't use this version of the code to parse v1 documents.
I'm not sure if you would like to build in multi-version support. Otherwise my best idea is to fork v1 of this repo and publish ofn-dfc-connector-v1 gem with a separate namespace so that both libraries can be loaded in the same app. Then, depending on the incoming request to our API, we can use either library to process the data. What do you think?
Yes I think you're right, if you still want to use the v1 we should publish two separate packages because it will be too complicated to support multi-version. And I should rename this version to 2.0.0 since there are breaking changes. |
No description provided.