Refactor monolithic CLI index_test into specialized files#2106
Merged
rafal-hawrylak merged 1 commit intomainfrom Mar 10, 2026
Merged
Refactor monolithic CLI index_test into specialized files#2106rafal-hawrylak merged 1 commit intomainfrom
rafal-hawrylak merged 1 commit intomainfrom
Conversation
rafal-hawrylak
requested review from
andrzej-grudzien,
apilaskowski,
ikholopov-omni and
kolina
apilaskowski
reviewed
Mar 9, 2026
apilaskowski
reviewed
Mar 9, 2026
rafal-hawrylak
force-pushed
the
refactor_cli_tests
branch
3 times, most recently
from
468286b to
6e2793d
Compare
apilaskowski
reviewed
Mar 9, 2026
apilaskowski
reviewed
Mar 9, 2026
Collaborator
apilaskowski
left a comment
apilaskowski
left a comment
There was a problem hiding this comment.
+1 from me on this change
Lets have second positive review before submitting.
rafal-hawrylak
force-pushed
the
refactor_cli_tests
branch
2 times, most recently
from
9c086e3 to
39ae864
Compare
* refactor: decompose monolithic cli/index_test.ts into modular components - Extract shared test utilities into cli/index_test_base.ts - Create dedicated test files for help, init, project, compile, and run commands - Update cli/BUILD to reflect the new modular test structure
rafal-hawrylak
force-pushed
the
refactor_cli_tests
branch
from
39ae864 to
596a3e0
Compare
kolina
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decomposes the large cli/index_test.ts into multiple files (help, init, project, compile, run, e2e) to improve maintainability and test isolation.