Skip to content

JiT: protos update to enable execution in CLI#2107

Merged
rafal-hawrylak merged 1 commit intomainfrom
core_jit_enhancements
Mar 12, 2026
Merged

JiT: protos update to enable execution in CLI#2107
rafal-hawrylak merged 1 commit intomainfrom
core_jit_enhancements

Conversation

@rafal-hawrylak
Copy link
Collaborator

@rafal-hawrylak rafal-hawrylak commented Mar 9, 2026

Updates the proto files to support execution in CLI.

@rafal-hawrylak rafal-hawrylak force-pushed the core_jit_enhancements branch from 3da6a8f to 5242396 Compare March 9, 2026 11:39
@rafal-hawrylak rafal-hawrylak marked this pull request as ready for review March 9, 2026 11:44
@rafal-hawrylak rafal-hawrylak requested a review from a team as a code owner March 9, 2026 11:44
@rafal-hawrylak rafal-hawrylak enabled auto-merge (squash) March 9, 2026 11:44
Copy link
Collaborator

@ikholopov-omni ikholopov-omni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both action descriptor are not planned to be dynamic. Please don't proceed with this direction.

@ikholopov-omni ikholopov-omni disabled auto-merge March 9, 2026 11:48
@ikholopov-omni ikholopov-omni marked this pull request as draft March 9, 2026 11:48
@rafal-hawrylak rafal-hawrylak force-pushed the core_jit_enhancements branch from 5242396 to 961c70e Compare March 9, 2026 12:11
@rafal-hawrylak rafal-hawrylak changed the title Enhance JiT compiler with action descriptors and metadata support JiT: protos update to enable execution in CLI Mar 9, 2026
@rafal-hawrylak rafal-hawrylak marked this pull request as ready for review March 9, 2026 12:56
@rafal-hawrylak rafal-hawrylak enabled auto-merge (squash) March 9, 2026 12:57
@rafal-hawrylak rafal-hawrylak force-pushed the core_jit_enhancements branch 2 times, most recently from 3c05640 to 753e397 Compare March 9, 2026 13:39
@rafal-hawrylak rafal-hawrylak self-assigned this Mar 9, 2026
@kolina kolina disabled auto-merge March 10, 2026 00:18
Copy link
Contributor

@kolina kolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase this PR after merging #2106? To remove the diff caused by index test splitting. Applies to other PRs as well

P.S. I've disabled auto-merge (let's not turn it on if you assign multiple reviewers)

@rafal-hawrylak rafal-hawrylak force-pushed the core_jit_enhancements branch 2 times, most recently from 2501cd4 to cc0cdc8 Compare March 10, 2026 14:22
@rafal-hawrylak
Copy link
Collaborator Author

Can you please rebase this PR after merging #2106? To remove the diff caused by index test splitting. Applies to other PRs as well

P.S. I've disabled auto-merge (let's not turn it on if you assign multiple reviewers)

Yup, browsing PRs in GitHub that depend on changes from other PRs that have not yet been merged is painful. It requires from the reviewer to pick the commits only from given PRs to show the actual scope of changes. Not very convenient. Since the #2106 is already merged I did rebase. But for all the consecutive PRs / branches even though they are rebased, in GitHub they show all the commits even from upstream branches :/.

- Enhance error coercion in common/errors/errors.ts
- Sync protos/execution.proto and protos/jit.proto with new fields
@rafal-hawrylak rafal-hawrylak merged commit 412d523 into main Mar 12, 2026
6 checks passed
@rafal-hawrylak rafal-hawrylak deleted the core_jit_enhancements branch March 12, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants