This repository was archived by the owner on Apr 23, 2024. It is now read-only.
Feature flag to conditionally compile with parquet support#174
Closed
JakeBecker wants to merge 1 commit into
Closed
Feature flag to conditionally compile with parquet support#174JakeBecker wants to merge 1 commit into
JakeBecker wants to merge 1 commit into
Conversation
Owner
|
@JakeBecker Sorry, I'm just catching up with PRs. If you can fix the merge conflict I will merge this, |
jthelin
reviewed
Oct 28, 2018
|
|
||
| lazy_static = "1.0" | ||
| parquet = "0.3.0" | ||
| parquet = { version = "0.3.0", optional = true } |
There was a problem hiding this comment.
Suggested change
| parquet = { version = "0.3.0", optional = true } | |
| parquet = { version = "0.4.1", optional = true } |
Owner
|
I am closing this PR because DataFusion is now being donated to the Apache Arrow project (see apache/arrow#3399). Thanks for your contribution and I hope that you will consider raising a new PR against Apache Arrow once the above PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet support breaks compilation for the dylib or cdylib crate types, which are necessary to create bindings to use Datafusion from another language. (Issue #173 ) This doesn't exactly fix it, but it allows me to disable Parquet support so cdylib compilation can succeed.
I am a novice at Rust, and I'm happy to receive feedback if I've gone about this the wrong way.