Skip to content

fix: freeze displayed provider for results#396

Merged
hanneshapke merged 2 commits into
dataiku:mainfrom
GodHad:fix-freeze-provider-results
May 7, 2026
Merged

fix: freeze displayed provider for results#396
hanneshapke merged 2 commits into
dataiku:mainfrom
GodHad:fix-freeze-provider-results

Conversation

@GodHad
Copy link
Copy Markdown
Contributor

@GodHad GodHad commented May 4, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@hanneshapke
Copy link
Copy Markdown
Collaborator

@GodHad Thank you for your PR. Can you please explain your motivation for your code change / PR?

@hanneshapke
Copy link
Copy Markdown
Collaborator

The link to the CLA is https://github.com/dataiku/kiji-proxy/blob/1f172d2a29fc570e5bf326e7915eb28dc0cc9809/.github/cla/CLA.md

you can sign the CLA by posting "recheck"

@GodHad
Copy link
Copy Markdown
Contributor Author

GodHad commented May 4, 2026

Thanks for the review.
My motivation for this change is to avoid a misleading provider label in the demo UI. Before this PR, the request was sent using the provider selected at submit time, but the result labels continued to read from the currently selected provider. That meant changing providers while a request was in flight, or after results were shown, could make an old response appear as if it came from a different provider.
This PR freezes the provider associated with the submitted request for the displayed result and disables provider switching while processing, so the request/response boxes stay consistent with the provider actually used.

recheck

@GodHad
Copy link
Copy Markdown
Contributor Author

GodHad commented May 4, 2026

recheck

@hanneshapke
Copy link
Copy Markdown
Collaborator

@GodHad Thank you for your explanation. Let me review your PR.

I will also review the CLA mechanism.

@hanneshapke
Copy link
Copy Markdown
Collaborator

@GodHad please sign by posting "I have read the CLA Document and I hereby sign the CLA" as a Pull Request comment

Thank you

@hanneshapke
Copy link
Copy Markdown
Collaborator

One more ask @GodHad : in this pr, could you please add your name to the contributors.md file? Thank you.

I can then restamp the pr.

Copy link
Copy Markdown
Collaborator

@hanneshapke hanneshapke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name to the contributors.md file. Thank you

@GodHad
Copy link
Copy Markdown
Contributor Author

GodHad commented May 5, 2026

I have read the CLA Document and I hereby sign the CLA

@hanneshapke
Copy link
Copy Markdown
Collaborator

@Davidnet Looks like this PR is in response to your reported issue: #137

@hanneshapke
Copy link
Copy Markdown
Collaborator

recheck

@hanneshapke hanneshapke merged commit f72c281 into dataiku:main May 7, 2026
7 of 10 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants