fix: hardcode onnxruntime to 1.24.2#406
Merged
Merged
Conversation
Previous changes assumed multiple ONNX Runtime versions could be supported; hardcoding to a single version (1.24.2) to align with the onnxruntime_go v1.27.0 C API headers and avoid version mismatches.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
Pins the project’s ONNX Runtime stack to a single compatible version by downgrading onnxruntime_go and updating development defaults/documentation to consistently use ONNX Runtime 1.24.2, reducing version drift and runtime/header mismatches.
Changes:
- Pin Go binding
github.com/yalue/onnxruntime_gotov1.27.0. - Switch local development default model variant to
quantized. - Update the development guide to install/download/copy ONNX Runtime
1.24.2.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/backend/config/config.development.json | Default local config now uses the quantized model variant. |
| go.mod | Pins onnxruntime_go to v1.27.0 to match the intended ORT C API compatibility. |
| go.sum | Adds checksums for onnxruntime_go v1.27.0 (but retains v1.28.0 sums). |
| docs/02-development-guide.md | Updates ONNX Runtime install/download instructions to 1.24.2. |
Comments suppressed due to low confidence (1)
docs/02-development-guide.md:112
- On Linux, these steps copy the shared library to
./build/libonnxruntime.so, but the backend’s ONNX loader searches for versioned filenames like./build/libonnxruntime.so.1.24.2(or usesONNXRUNTIME_SHARED_LIBRARY_PATHif set). As written, following the guide on Linux likely results in the library not being found at runtime. Update the instructions to either copy/symlink tobuild/libonnxruntime.so.1.24.2(optionally also createbuild/libonnxruntime.sosymlink) or document settingONNXRUNTIME_SHARED_LIBRARY_PATHon Linux to the copied.sopath.
cp "$LIB_PATH" ./build/libonnxruntime.1.24.2.dylib
# Find and copy library (Linux)
LIB_PATH=$(find .venv -name "libonnxruntime.so.*" | head -1)
cp "$LIB_PATH" ./build/libonnxruntime.so
</details>
---
💡 <a href="/dataiku/kiji-proxy/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
Comment on lines
142
to
+145
| # Linux | ||
| wget https://github.com/microsoft/onnxruntime/releases/download/v1.25.0/onnxruntime-linux-x64-1.25.0.tgz | ||
| tar -xzf onnxruntime-linux-x64-1.25.0.tgz | ||
| cp onnxruntime-linux-x64-1.25.0/lib/libonnxruntime.so.1.25.0 build/libonnxruntime.so | ||
| wget https://github.com/microsoft/onnxruntime/releases/download/v1.24.2/onnxruntime-linux-x64-1.24.2.tgz | ||
| tar -xzf onnxruntime-linux-x64-1.24.2.tgz | ||
| cp onnxruntime-linux-x64-1.24.2/lib/libonnxruntime.so.1.24.2 build/libonnxruntime.so |
Member
Author
|
Follow-up issue for unifying the ONNX Runtime version: #407 |
hanneshapke
requested changes
May 8, 2026
Collaborator
hanneshapke
left a comment
There was a problem hiding this comment.
Also please sign the CLA.
| "LogVerbose": true | ||
| }, | ||
| "ModelVariant": "trained", | ||
| "ModelVariant": "quantized", |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
hanneshapke
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.24.2and pinonnxruntime_gotov1.27.0. The previous bump assumed multiple ONNX Runtime versions could be supported; in practice the C API headers inonnxruntime_gorequire a specific matching runtime version, so we're hardcoding a single version for now.docs/02-development-guide.mdso all install/download/verify steps reference1.24.2.Follow-up
Test plan
go build ./...succeeds with the pinnedonnxruntime_go v1.27.0libonnxruntime.1.24.2.dylib/libonnxruntime.so