Skip to content

Part 2/2: Add TLS support #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2019
Merged

Part 2/2: Add TLS support #157

merged 5 commits into from
Jul 10, 2019

Conversation

guzman-raphael
Copy link
Collaborator

Fix #103

dimitri-yatsenko
dimitri-yatsenko requested changes Jun 17, 2019
View reviewed changes
Copy link
Member

@dimitri-yatsenko dimitri-yatsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rather than "period-based', refer to the MAJOR.MINOR.PATCH versioning scheme as "semantic versioning".
  • Rename the function so that it is clear what it does, e.g. compareVersions

@dimitri-yatsenko dimitri-yatsenko merged commit 3a1daa4 into datajoint:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitri-yatsenko dimitri-yatsenko dimitri-yatsenko approved these changes

@eywalker eywalker Awaiting requested review from eywalker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for secure connections

2 participants

@guzman-raphael @dimitri-yatsenko