Modify update to allow nullable updates for strings/date #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify update to allow nullable updates for strings/date
Fix issue in reading schema MySQL8
eywalker
suggested changes
Apr 20, 2020
+dj/Relvar.m
Outdated
| valueStr = 'NULL'; | ||
| value = {}; | ||
| case header.attributes(ix).isString | ||
| assert(dj.lib.isString(value), 'Value must be a string') |
There was a problem hiding this comment.
Under this code, it appears that passing value of an empty string '' will make it interpreted as NULL but that's not what we'd like. We only want to accept [] as a value for empty/NULL for non numeric types. This assertion will fail for [] and also unfortunately isemtpy(value) is true for value of ''
eywalker
suggested changes
Apr 22, 2020
+dj/Relvar.m
Outdated
| valueStr = 'NULL'; | ||
| value = {}; | ||
| case header.attributes(ix).isString | ||
| assert(dj.lib.isString(value), 'Value must be a string') |
There was a problem hiding this comment.
Actually I don't think this will allow for inserting [] as isString([]) would be false.
Fix null logic, add tests, and fix linting
| valueStr = '"{M}"'; | ||
| value = {value}; | ||
| end | ||
| valueStr = '"{M}"'; |
There was a problem hiding this comment.
how is NULL handled here?
There was a problem hiding this comment.
oh, I see, it's already handled together for all attribute types.
eywalker
approved these changes
Apr 22, 2020
| assert(~header.attributes(ix).iskey, 'cannot update a key value. Use insert(..,''REPLACE'') instead') | ||
| assert(numel(ix)==1, 'invalid attribute name'); | ||
| assert(~header.attributes(ix).iskey, ... | ||
| 'cannot update a key value. Use insert(..,''REPLACE'') instead'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #211
also:
createSchemaon MySQL8