Patch virtual classes regression bug, attribute comment parsing bug, initial config load bug, and add issue templates #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly, and add GH issues templates.
Patch virtual classes regression bug, attribute comment parsing bug, and add issue templates
Remove blank issue option
Add placeholder for when community engagement policy is ready to share
|
@guzman-raphael , I've installed 3.4.1 from your fork, tested the fix and here confirming that it has resolved issue #336. |
Fix issue with double colon attribute comment parsing and dj.config initial load
guzman-raphael
changed the title
|
@guzman-raphael , installed and tested 3.4.2, confirming here that issue #335 is resolved |
Update regex to be comparible to dj-python equivalent
dimitri-yatsenko
approved these changes
Dec 16, 2020
+dj/Computed.m
Outdated
| classdef Computed < dj.internal.AutoPopulate | ||
| % defines a computed table | ||
| properties(Constant) | ||
| tierRegexp = ['(?<computed>' ... |
There was a problem hiding this comment.
I think sprintf would be clearer than these types of concatenations.
There was a problem hiding this comment.
@dimitri-yatsenko Updated styling per your feedback.
+dj/Imported.m
Outdated
| classdef Imported < dj.internal.AutoPopulate | ||
| % defines an imported table | ||
| properties(Constant) | ||
| tierRegexp = ['(?<imported>' ... |
There was a problem hiding this comment.
use sprintf for formatted strings.
guzman-raphael
changed the title
dimitri-yatsenko
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSchema()for existing schema withdj.Imported(and likelydj.Computed) tables #336 issue of instantiating classes with abstract methods (dj.Imported,dj.Computed) by using super classdj.internal.UserRelationand parsing table name to determine table type. This use case is triggered when using the virtual class operation. Addeddj.ERD.getTierutility method.attribute's type - incorrectly read from the comments #335 by properly escaping"and/characters in attribute comments.This resolves the blocker that @ttngu207 reported related to Moser. Thinking to release
3.4.1as introduced here and rename milestone from3.4.1->3.4.2if others agree.Fix #336
Fix #210
Fix #335